#64659 Fix bulk action validation notice and a11y announcement#11077
#64659 Fix bulk action validation notice and a11y announcement#11077PANawkar wants to merge 5 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @pratik.nawkar@xecurify.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
PANawkar
changed the title
joedolson
left a comment
joedolson
left a comment
There was a problem hiding this comment.
Minor text change in the new string, but otherwise I think this is good!
src/js/_enqueues/admin/common.js
Outdated
| var errorMessage = __( 'Please select at least one item to perform this action on.' ); | ||
| var errorMessage = value !== '-1' ? | ||
| __( 'Please select at least one item to perform this action on.' ) : | ||
| __( 'Please select a bulk action before clicking Apply.' ); |
There was a problem hiding this comment.
I'm thinking this text should just be "Please select a bulk action" or "Please select a bulk action to perform". Specifically naming the button to click could cause problems for translators, as they'll need to correlate the two strings between translations.
There was a problem hiding this comment.
@joedolson I’ve updated the text as suggested. Please have a look when you get a chance.
2 participants
Trac ticket:
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.